fix: handle ID token expiry time and premature expiration MONGOSH-2145 MONGOSH-2147 #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that we do not return tokens from a token set that the driver is currently rejecting (in the sense of calling the OIDC callback again and referring to it via the driver `refreshToken` property).
lerouxb
approved these changes
Apr 14, 2025
lerouxb
reviewed
Apr 14, 2025
src/plugin.ts
Outdated
| const tokenSetId = getStableTokenSetId(state.currentTokenSet.set); | ||
|
|
||
| // We would not want to return the access token or ID token of a token set whose | ||
| // accompanying refresh token was passed to us by |
There was a problem hiding this comment.
Yeah, thanks for pointing this out 😅 Was meant to be the driver, fixed this in 61e6147
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: use ID token expiry if
passIdTokenAsAccessTokenis set MONGOSH-2145fix: do not return token to driver which is being rejected MONGOSH-2147
Ensure that we do not return tokens from a token set that the driver
is currently rejecting (in the sense of calling the OIDC callback
again and referring to it via the driver
refreshTokenproperty).